Skip to content

Commit

Permalink
Try to support Python 3.9 for signer
Browse files Browse the repository at this point in the history
This should start failing on CI since we do use some 3.10 features
currently.

This only tests signer on python 3.9: repository has an annoying
dependency issue that would require downgrading urllib3...
  • Loading branch information
jku committed Sep 9, 2024
1 parent 264be32 commit 1962885
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
20 changes: 18 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,29 @@ permissions: {}

jobs:
test:
runs-on: ubuntu-latest
permissions:
contents: read
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
pyversion: ['3.12']
toxenv: [lint-signer, lint-repo, test-signer, test-repo, test-e2e]
# run signer tests/lint also on 3.9 and macos
include:
- pyversion: '3.9'
toxenv: [lint-signer]
os: ubuntu-latest
- pyversion: '3.9'
toxenv: test-signer
os: ubuntu-latest
- pyversion: '3.9'
toxenv: lint-signer
os: macos-latest
- pyversion: '3.9'
toxenv: test-signer
os: macos-latest
runs-on: ${{ matrix.os }}
env:
TOXENV: ${{ matrix.toxenv }}

Expand All @@ -24,7 +40,7 @@ jobs:

- uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3 # v5.2.0
with:
python-version: '3.12'
python-version: ${{ matrix.pyversion }}
cache: 'pip'
cache-dependency-path: |
signer/pyproject.toml
Expand Down
2 changes: 1 addition & 1 deletion signer/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ dependencies = [
"tuf ~= 3.1",
"click ~= 8.1",
]
requires-python = ">=3.10"
requires-python = ">=3.9"
dynamic = ["version"]

[project.scripts]
Expand Down

0 comments on commit 1962885

Please sign in to comment.