Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep targets file path #632

Merged

Conversation

mrjoelkamp
Copy link
Contributor

Summary

  • fixes bug in DownloadTarget for target files that are in subdirectories that are more than one level deep

Fixes

fixes #631

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.90%. Comparing base (14cf073) to head (23b08c0).
Report is 20 commits behind head on master.

Files Patch % Lines
metadata/updater/updater.go 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
+ Coverage   70.51%   72.90%   +2.38%     
==========================================
  Files          10       10              
  Lines        2123     1657     -466     
==========================================
- Hits         1497     1208     -289     
+ Misses        505      328     -177     
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MDr164 MDr164 enabled auto-merge (rebase) May 3, 2024 14:44
@trishankatdatadog
Copy link
Member

Thanks @MDr164.

@mrjoelkamp Would you mind terribly much rebasing against base, please?

auto-merge was automatically disabled May 4, 2024 20:24

Rebase failed

@MDr164 MDr164 merged commit 1ab2a38 into theupdateframework:master May 4, 2024
23 checks passed
@mrjoelkamp mrjoelkamp deleted the fix-deep-target-file-path branch May 5, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: deep target file paths for consistent snapshots
4 participants