-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: spec version field to follow semver #512
fix!: spec version field to follow semver #512
Conversation
72606ae
to
19dac3e
Compare
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
498647e
to
5fe3c6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this break new clients on old metadata? Could/should we make it tolerant of the exact string "1.0"?
From what I've seen I haven't found a place where go-tuf actually takes into account the format of the spec_version value, so thus why I think it shouldn't break any new or existing go-tuf clients. Nevertheless, I've marked it as breaking due to the fact that there might be some other client implementation (go or something else) that actually takes into account this format. |
Closing this one since the code base change and is no longer relevant |
The following PR updates the initial spec_version values for all metadata roles so they comply with the specification by following the SemVer format.
Note that if there's an implementation that depends on a non-spec compliant versioning it may be affected by this change, so thus why it is marked as breaking.
Related #206
Release Notes:
Types of changes:
!
, as infeat!: change foo
).Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following requirements: