Skip to content

Commit

Permalink
Move tolerance to geometry
Browse files Browse the repository at this point in the history
It is starting to see use there, and I think it makes more sense for
`approx` to depend on `geometry` than the other way around. `geometry`
can be seen to provide low-level geometry primitives, which `approx`,
which is higher-level functionality, should depend on at some point.
  • Loading branch information
hannobraun committed Sep 13, 2024
1 parent dc0c010 commit 8f57025
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
7 changes: 2 additions & 5 deletions crates/fj-core/src/algorithms/approx/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ pub mod half_edge;
pub mod shell;
pub mod sketch;
pub mod solid;
pub mod tolerance;

mod circle;
mod curve;
Expand All @@ -25,10 +24,8 @@ use vertex::VertexApproxCache;

use crate::geometry::Geometry;

pub use self::{
circle::PathApproxParams,
tolerance::{InvalidTolerance, Tolerance},
};
pub use self::circle::PathApproxParams;
pub use crate::geometry::{InvalidTolerance, Tolerance};

/// Approximate an object
pub trait Approx: Sized {
Expand Down
2 changes: 2 additions & 0 deletions crates/fj-core/src/geometry/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ mod curve;
mod geometry;
mod path;
mod surface;
mod tolerance;
mod vertex;

pub use self::{
Expand All @@ -13,5 +14,6 @@ pub use self::{
geometry::Geometry,
path::Path,
surface::SurfaceGeom,
tolerance::{InvalidTolerance, Tolerance},
vertex::{LocalVertexGeom, VertexGeom},
};
File renamed without changes.

0 comments on commit 8f57025

Please sign in to comment.