Pipeline2.0: low hanging fruits - move buffers' common params to struct sof_audio_buffer. #9499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a first / the first procedure / function Signed-off-by: Marcin Szkudlinski <[email protected]>
is_shared is a flag indicating that a buffer is shared between cores. This property is common for all types of audio buffers and should be kept in a base structure Signed-off-by: Marcin Szkudlinski <[email protected]>
marcinszkudlinski
requested review from
bardliao,
pblaszko,
a team,
tlissows,
fkwasowi,
RanderWang,
abonislawski,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
approved these changes
Sep 20, 2024
cujomalainey
approved these changes
Sep 20, 2024
lyakh
reviewed
Sep 23, 2024
kv2019i
approved these changes
Sep 23, 2024
|
there's a problem with CI loadable library test, checking |
hw_params_configured is a flag indicating that a buffer params has been already set, and should be kept in the same structure as the params themselves this commit moves hw_params_configured to sof_audio_stream_params and introduces API to handle the flag Signed-off-by: Marcin Szkudlinski <[email protected]>
walking flag is not really needed for data buffering, rather for pipeline iteration procedures, so it should not be in sof_audio_buffer structure. But before in order to make possible usage of other buffer types than comp_buffer before pipeline2.0 is ready, it must be kept there. Signed-off-by: Marcin Szkudlinski <[email protected]>
marcinszkudlinski
force-pushed
the
pipeline2_0_004
branch
from
6cf701c
to
ccae5e5
Compare
chmap is a parameter common for all types of buffers, should be accessible through sink/src api, so it needs to be kept in sof_audio_stream_params an API inroduced for accessing the parameter Signed-off-by: Marcin Szkudlinski <[email protected]>
marcinszkudlinski
force-pushed
the
pipeline2_0_004
branch
from
ccae5e5
to
dd4c512
Compare
|
internal CI that was failing is green, jenkins did not start. Lately there was couple of similar problems in several PRs BlobNotFoundThe specified blob does not exist. RequestId:edb2f1ad-201e-0086-7fa7-105dd6000000 Time:2024-09-27T06:33:40.4681943Z |
|
SOFCI TEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves many of parameters that are common for all buffers to struct sof_audio_buffer
there are 4 left:
and will be moved to sof_audio_buffer in next PR