lib.sh: initialize with alsactl before setting proper alsa settings #966
Conversation
alsaclt init will try to initialize all sound devices to a default state. It doesn't guarantee to set default for all, but good to start with when proper alsa settings are desired. Signed-off-by: Fred Oh <[email protected]>
|
|
||
| # Initialize alsa settings first | ||
| alsactl init | ||
|
|
There was a problem hiding this comment.
@fredoh9 Note, this should also get the UCM defaults, but it is worth double-checking this does happen (alsactl also has " -D,--ucm-defaults execute also the UCM 'defaults' section" option but AFAIK this should not be needed)
Example default mixer settings for SOF HDA cards are here in alsa-ucm:
https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/Intel/sof-hda-dsp/sof-hda-dsp.conf
The "True.BootSequence" sections should be executed to put the card into a sane default state.
FYI @greg-intel @marc-hb
|
One of the device failures was related to |
| @@ -802,6 +802,10 @@ set_alsa_settings() | |||
| { | |||
| # ZEPHYR platform shares same tplg, remove '_ZEPHYR' from platform name | |||
| local PNAME="${1%_ZEPHYR}" | |||
|
|
|||
| # Initialize alsa settings first | |||
There was a problem hiding this comment.
Maybe this can be an echo rather than a comment? Likewise with the other comment below. The only set -x I saw in this file were wrapped in sub-shells. Approving regardless.
There was a problem hiding this comment.
I agree with @greg-intel , this looks like a big change and it seems very "quiet": I tried this command on my system and absolutely nothing was printed. Also, dlogi "Run alsa setting for $PNAME" runs AFTER this, could be confusing.
So either a new dlogi or maybe just this:
- alsactl init
+ alsactl --debug initEDIT: no, --debug is too verbose. A dlogi would be great.
There was a problem hiding this comment.
So either a new dlogi or maybe just this...
@fredoh9 , ping?
There was a problem hiding this comment.
I lost the momentum, need to review what was my intention at first
|
Merging this during the holiday season looks risky to me. Also, Fred is on vacation for a couple weeks. |
|
SOFCI TEST |
|
LNL failure in https://sof-ci.01.org/softestpr/PR966/build659/devicetest/index.html is unrelated (thesofproject/linux#5109) The MTL timeout in https://sof-ci.01.org/softestpr/PR966/build657/devicetest/index.html is very unusual but can't possibly be related either. EDIT: hard, completely silent crash that happened on Everything else is 100% green. @fredoh9 , @plbossart , @ujfalusi , @kv2019i do we still want this Maybe this could help with some of the MAX volume issues? (e.g. thesofproject/linux#5048, thesofproject/linux#3766, etc.) |
alsaclt init will try to initialize all sound devices to a default state. It doesn't guarantee to set default for all, but good to start with when proper alsa settings are desired.
Signed-off-by: Fred Oh [email protected]