Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp: Wallet connection info alert #909

Closed
wants to merge 2 commits into from

Conversation

kpyszkowski
Copy link
Contributor

Closes: AENG-24

This pull request focuses on refactoring the wallet connection error handling system to use alerts of multiple types. The changes include renaming components and contexts, updating imports and hooks, and modifying the structure of connection alerts.

Changes:

  • Renamed 'Error' to be 'Alert' in terms of WalletConnectionModal component
  • Adjust Alert component styling
  • Adjust Modal component styling to match designs
  • Restructured error constants and extracted errors to separate file as alerts
Before: image
After: image

@kpyszkowski kpyszkowski added the 🎨 dApp dApp label Dec 2, 2024
@kpyszkowski kpyszkowski self-assigned this Dec 2, 2024
Copy link

linear bot commented Dec 2, 2024

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for acre-dapp ready!

Name Link
🔨 Latest commit 9f905b8
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/674d9c34821885000867b9ce
😎 Deploy Preview https://deploy-preview-909--acre-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit 9f905b8
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/674d9c34e4ffe7000807e62f
😎 Deploy Preview https://deploy-preview-909--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts and then let's do a review. On the main branch, there are already some improvements for WalletConnectionAlert.

@kpyszkowski
Copy link
Contributor Author

Too much major changes to resolve conflicts. Closing this pull request in favor of #917.

@kpyszkowski kpyszkowski closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants