Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow booting without keyboard or mouse #1082

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

YtvwlD
Copy link
Contributor

@YtvwlD YtvwlD commented Dec 12, 2023

If a PS/2 controller exists, but no keyboard or mouse is plugged in, resetting those devices fails. Handle this gracefully by logging an error and continuing without them.

I really don't know much about PS/2 but this allows booting on a real PC without keyboard or mouse (and it correctly detects which of those is missing).

If a PS/2 controller exists, but no keyboard or mouse is plugged in,
resetting those devices fails. Handle this gracefully by logging an
error and continuing without them.
Copy link
Member

@kevinaboos kevinaboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much appreciated!

@kevinaboos kevinaboos merged commit e06c84a into theseus-os:theseus_main Dec 13, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
* If a PS/2 controller exists, but no keyboard or mouse is plugged in,
  `reset`ting those devices fails.
* This PR handles that situation gracefully by logging an error
  and allowing initialization to continue without them. e06c84a
github-actions bot pushed a commit to tsoutsman/Theseus that referenced this pull request Dec 13, 2023
* If a PS/2 controller exists, but no keyboard or mouse is plugged in,
  `reset`ting those devices fails.
* This PR handles that situation gracefully by logging an error
  and allowing initialization to continue without them. e06c84a
@YtvwlD YtvwlD deleted the no-mouse branch December 14, 2023 14:28
github-actions bot pushed a commit to YtvwlD/Theseus that referenced this pull request Jul 5, 2024
* If a PS/2 controller exists, but no keyboard or mouse is plugged in,
  `reset`ting those devices fails.
* This PR handles that situation gracefully by logging an error
  and allowing initialization to continue without them. e06c84a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants