Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change nodata value when equal to Nan after downloading files form openeo #129

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Change nodata value when equal to Nan after downloading files form openeo #129

wants to merge 3 commits into from
+39 −12

Conversation

KriWay-LV
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.05%. Comparing base (3a699f4) to head (8f403c2).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
cropclassification/util/openeo_util.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   60.11%   60.05%   -0.06%     
==========================================
  Files          34       34              
  Lines        4332     4336       +4     
==========================================
  Hits         2604     2604              
- Misses       1728     1732       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

theroggy
theroggy approved these changes Aug 12, 2024
View reviewed changes
Copy link
Owner

@theroggy theroggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, but otherwise looks nice!

cropclassification/util/openeo_util.py
@@ -398,6 +398,8 @@ def download_file(url, target):


def postprocess_image(path: Path, band_descriptions: Optional[list[str]]):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably most logical to add the nodata_value parameter here as well?

theroggy
theroggy requested changes Aug 12, 2024
View reviewed changes
Copy link
Owner

@theroggy theroggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idee: misschien handiger als de nodata value, als ze gezet moet worden, in het imageprofile opgenomen kan worden?

@KriWay-LV KriWay-LV marked this pull request as draft August 14, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theroggy theroggy theroggy requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KriWay-LV @theroggy