Cancel subscription at period end #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineLemaire
force-pushed
the
cancel_at_period_end
branch
2 times, most recently
from
492fdb8
to
f052f84
Compare
AntoineLemaire
force-pushed
the
cancel_at_period_end
branch
from
f052f84
to
8afb5e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version
2018-08-23of Stripe API, the optionat_period_endis no longer valid on CancelSubscriptionRequest and we need to usecancel_at_period_endin the UpdateSubscriptionRequest.I also made the customerReferences optionnal in the subscriptions endpoints as subscription reference is enough
POST /v1/subscriptions/:idhttps://stripe.com/docs/api/subscriptions/updateDELETE /v1/subscriptions/:idhttps://stripe.com/docs/api/subscriptions/cancelPS: I think this PR introduce a BC break as if you use API Version older than
2018-08-23, you won't be able to cancel subscription.