Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Intent implementation & off_session payments for Payment Intent #177

Merged
merged 4 commits into from
May 29, 2020

Conversation

sash
Copy link

@sash sash commented Apr 25, 2020

We had to extend the plugin a bit to fit our needs at Ampeco, and I'd like to offer it back to the community.

The implementation of Session Intent does not cover the full api - just the Create and Retrieve methods are implemented. The rest can be easily added afterwards!

We also needed the off_session option in payments intent - that why we needed the SetupIntent in the first place :)

@barryvdh
Copy link
Member

What does this do?

@aimeoscom
Copy link
Contributor

@barryvdh It enables token based payments. We created a pull request (#178) which does roughly the same but retrieves the token after a regular payment instead of using a separate SetupIntent request

@sash
Copy link
Author

sash commented May 1, 2020

Correct. The main difference being that using the setup intent there is no charge occurring the you only want to setup a credit card. That happens to be our use case

@hiqsol
Copy link

hiqsol commented May 20, 2020

We need this too.
Will this PR be taken?

@barryvdh
Copy link
Member

So now #178 is merged, is this still required / relevant?

@aimeos
Copy link

aimeos commented May 25, 2020

@barryvdh Yes, it's similar but doesn't perform an initial payment like #178 does

@barryvdh barryvdh merged commit a91faeb into thephpleague:master May 29, 2020
@sharald
Copy link
Contributor

sharald commented Jun 12, 2020

This PR and #178 both adds the method AuthorizeRequest::setOffSession(). The build currently fails, so this needs to be fixed.

@tafid
Copy link

tafid commented Jun 12, 2020

This PR and #178 both adds the method AuthorizeRequest::setOffSession(). The build currently fails, so this needs to be fixed.

I have fixed it in #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants