-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Intent implementation & off_session payments for Payment Intent #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What does this do? |
Correct. The main difference being that using the setup intent there is no charge occurring the you only want to setup a credit card. That happens to be our use case |
We need this too. |
So now #178 is merged, is this still required / relevant? |
hiqsol
approved these changes
May 29, 2020
tafid
approved these changes
May 29, 2020
This PR and #178 both adds the method AuthorizeRequest::setOffSession(). The build currently fails, so this needs to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to extend the plugin a bit to fit our needs at Ampeco, and I'd like to offer it back to the community.
The implementation of Session Intent does not cover the full api - just the Create and Retrieve methods are implemented. The rest can be easily added afterwards!
We also needed the off_session option in payments intent - that why we needed the SetupIntent in the first place :)