Fix error with missing payment method on 3DS payments #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miholeus
changed the title
domis86
suggested changes
Oct 18, 2019
| @@ -37,6 +37,10 @@ public function getData() | |||
| $data['return_url'] = $this->getReturnUrl(); | |||
| } | |||
|
|
|||
| if ($this->getPaymentMethod()) { | |||
| $data['payment_method'] = $this->getPaymentMethod(); | |||
| } | |||
There was a problem hiding this comment.
Please add some explanation why and how to use this new param - either in the description in top of file:
or above this if.
Would be good if you can add link from official Stripe doc about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I tested 3ds payments and found an error. If you have a failed payment and you try to process it once more, then Stripe will ask you for payment method. And we don't have that parameter in
ConfirmPaymentIntentRequest. So I added it. Now you can try to process payment intent once more.