Stricter tests

thephpleague · May 14, 2018 · 0905bb7 · 0905bb7
1 parent 61d8e3c
commit 0905bb7
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 11 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit backupGlobals="false"
          backupStaticAttributes="false"
-         bootstrap="tests/bootstrap.php"
+         bootstrap="vendor/autoload.php"
          colors="true"
          convertErrorsToExceptions="true"
          convertNoticesToExceptions="true"

diff --git a/tests/Omnipay/Common/CreditCardTest.php b/tests/Omnipay/Common/CreditCardTest.php
@@ -50,6 +50,9 @@ public function testGetParamters()
         $this->assertSame(2016, $parameters['expiryYear']);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testValidateFixture()
     {
         $this->card->validate();

diff --git a/tests/Omnipay/Common/HelperTest.php b/tests/Omnipay/Common/HelperTest.php
@@ -43,12 +43,18 @@ public function testValidateLuhnNull()
         $this->assertTrue($result);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testInitializeIgnoresNull()
     {
         $target = m::mock();
         Helper::initialize($target, null);
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testInitializeCallsSetters()
     {
         $target = m::mock('\Omnipay\Common\CreditCard');
@@ -58,6 +64,9 @@ public function testInitializeCallsSetters()
         Helper::initialize($target, array('name' => 'adrian', 'number' => '1234'));
     }
 
+    /**
+     * @doesNotPerformAssertions
+     */
     public function testInitializeIgnoresInvalidParameters()
     {
         $target = m::mock('\Omnipay\Common\CreditCard');

diff --git a/tests/Omnipay/OmnipayTest.php b/tests/Omnipay/OmnipayTest.php
@@ -10,6 +10,8 @@ class OmnipayTest extends TestCase
     public function tearDown()
     {
         Omnipay::setFactory(null);
+
+        parent::tearDown();
     }
 
     public function testGetFactory()

diff --git a/tests/bootstrap.php b/tests/bootstrap.php