Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: split login process #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rymiyamoto
Copy link

@rymiyamoto rymiyamoto commented Mar 31, 2020

I don't think it's good to use goto statements.
For that reason, we reviewed the login process.

Please review.

@rymiyamoto rymiyamoto changed the title [refactor] split login process Refactor: split login process Mar 31, 2020
@frankdejonge
Copy link
Member

What was the problem with the goto statement? What concrete problem are you fixing with this PR?

@rymiyamoto
Copy link
Author

rymiyamoto commented Mar 31, 2020

Thank you for your reply.

I think that using goto statement is because the process of attempting to login is complicated.
It's not bad to use a goto statement, but it's not common, so I just split the process and refactored.

Also, the use of goto statements is likely to be complicated in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants