Fix user provided file/dir permission settings #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retain user provided file/dir permissions like 0775 or "0775" as octal int. Converting them with (int) yields incorrect values.
|
I don't really remember, but from what I do recall it's the yaml component that performs the octal conversion of this data: 0o755 and here we only cast octal int. |
|
@maxhelias my bad, I missed the correct octal number notation in the yaml. Using that it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retain user provided file/dir permissions like 0775 or "0775" as octal int. Converting them with (int) yields incorrect values, as the value is a string at this moment and
(int) "0775"will convert to 775 instead to 0775 (509 in decimal), resulting in some interesting file permissions later.