Merge pull request #182 from thephpleague/scrutinizer-fixes

Scrutinizer fixes
thephpleague · Sep 22, 2015 · 61efa29 · 61efa29
2 parents 38dff4e + 712276c
commit 61efa29
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,8 +3,15 @@ All notable changes to this project will be documented in this file.
 Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) principles.
 
 ## [Unreleased][unreleased]
+### Changed
+ - Tightened up some loose comparisons
+
 ### Fixed
  - Fixed missing "bin" directive in composer.json
+ - Updated a docblock to match recent changes to method parameters
+
+### Removed
+ - Removed unused variable from within QuoteProcessor's closure
 
 ## [0.11.0] - 2015-09-19
 ### Added

diff --git a/src/Block/Element/HtmlBlock.php b/src/Block/Element/HtmlBlock.php
@@ -117,7 +117,7 @@ public function handleRemainingContents(ContextInterface $context, Cursor $curso
 
         // Check for end condition
         if ($this->type >= self::TYPE_1_CODE_CONTAINER && $this->type <= self::TYPE_5_CDATA) {
-            if ($cursor->match(RegexHelper::getHtmlBlockCloseRegex($this->type))) {
+            if ($cursor->match(RegexHelper::getHtmlBlockCloseRegex($this->type)) !== null) {
                 $this->finalize($context);
             }
         }

diff --git a/src/Inline/Parser/CloseBracketParser.php b/src/Inline/Parser/CloseBracketParser.php
@@ -158,7 +158,7 @@ protected function tryParseInlineLinkAndTitle(Cursor $cursor)
 
         $cursor->advanceToFirstNonSpace();
 
-        if (!$cursor->match('/^\\)/')) {
+        if ($cursor->match('/^\\)/') === null) {
             return false;
         }
 

diff --git a/src/Inline/Parser/RawHtmlParser.php b/src/Inline/Parser/RawHtmlParser.php
@@ -14,7 +14,6 @@
 
 namespace League\CommonMark\Inline\Parser;
 
-use League\CommonMark\ContextInterface;
 use League\CommonMark\Inline\Element\Html;
 use League\CommonMark\InlineParserContext;
 use League\CommonMark\Util\RegexHelper;
@@ -30,7 +29,6 @@ public function getCharacters()
     }
 
     /**
-     * @param ContextInterface    $context
      * @param InlineParserContext $inlineContext
      *
      * @return bool

diff --git a/src/Inline/Processor/QuoteProcessor.php b/src/Inline/Processor/QuoteProcessor.php
@@ -21,7 +21,7 @@ class QuoteProcessor implements InlineProcessorInterface
 {
     public function processInlines(DelimiterStack $delimiterStack, Delimiter $stackBottom = null)
     {
-        $callback = function (Delimiter $opener, Delimiter $closer, DelimiterStack $stack) {
+        $callback = function (Delimiter $opener, Delimiter $closer) {
             // Open quote
             $openerInline = $opener->getInlineNode();
             $openerInline->setContent(