migrate: find+replace Option/Answer flag prop to flags and ensure always string[] type
#4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
changed the title
flag prop to flags and assume always arrayflag prop to flags and ensure always string[] type
jessicamcinchak
commented
Dec 20, 2024
| @@ -26,34 +26,8 @@ describe("Collecting flags", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test("Correctly collects flags when an option's `data.flag` prop is the legacy string format", () => { | |||
There was a problem hiding this comment.
No longer supporting an active and legacy format - with migration script, now officially all same string[] format !!
jessicamcinchak
changed the title
flag prop to flags and ensure always string[] typeflag prop to flags and ensure always string[] type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per data migration script here https://docs.google.com/spreadsheets/d/1Vtxp5BLweDPDooQoNhgOCYjCIBPRYIcOuyArGJRqOkI/edit?gid=0#gid=0
Relies on planx-core PR: theopensystemslab/planx-core#611