migrate: find+replace DrawBoundary dataFieldBoundary prop to fn and remove dataFieldArea prop
#4085
+68
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
changed the title
dataFieldBoundary to fn and remove dataFieldArea propdataFieldBoundary prop to fn and remove dataFieldArea prop
jessicamcinchak
commented
Dec 17, 2024
| value={formik.values.dataFieldArea} | ||
| onChange={formik.handleChange} | ||
| value={formik.values.fn} | ||
| disabled |
There was a problem hiding this comment.
This file is a good summary / convergence point of main significant changes throughout:
- Only support a single editor-facing data field prop (rather than two data fields)
- Many data fields (eg area in m2 & ha) can still be captured in passport/breadcrumbs by
handleSubmit, but editor's don't need to be concerned with naming of those
- Many data fields (eg area in m2 & ha) can still be captured in passport/breadcrumbs by
- Change the underlying prop name for the data field so it's picked up in graph styling, search facets by default
- Disable the data field input similar to PlanningConstraints & Pay as it's actually very important for integrations that it's called exactly this
- Change the actual data field value prefix from
property.toproposal.to better align to schema
Before:
After:
16 tasks
jessicamcinchak
changed the title
dataFieldBoundary prop to fn and remove dataFieldArea propdataFieldBoundary prop to fn and remove dataFieldArea prop
RODO94
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queueing up per migration plan: https://docs.google.com/spreadsheets/d/1Vtxp5BLweDPDooQoNhgOCYjCIBPRYIcOuyArGJRqOkI/edit?gid=0#gid=0
Planx-core counterpart here theopensystemslab/planx-core#594