migrate: find+replace Calculate output prop with fn
#4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Dec 17, 2024
| @@ -19,7 +19,6 @@ export const getFlowSchema = async (flowId: string) => { | |||
| planx_variable: | |||
| nodeData.data?.fn || | |||
| nodeData.data?.val || | |||
| nodeData.data?.output || | |||
There was a problem hiding this comment.
This is a key benefit - we only need to account for nodeData.data?.fn when getting a flow's "schema" ✔️
jessicamcinchak
commented
Dec 17, 2024
| @@ -9,7 +9,6 @@ const generalData: SearchFacets = ["data.fn", "data.val"]; | |||
| const fileUploadAndLabelData: SearchFacets = ["data.fileTypes.fn"]; | |||
|
|
|||
| const calculateData: SearchFacets = [ | |||
| "data.output", | |||
There was a problem hiding this comment.
This is another key benefit - data.output is now simply picked up by generalData search facets ✔️
16 tasks
RODO94
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Worked through the Calculate comp and the code in your branch and couldn't find any more refs to .output and looks like you got all the right fields changed.
Only comment I have is on that merge conflict, to do with the autocomplete data fields work, imagine we would want to take in that change into this PR?
|
@RODO94 now rebased to |
jessicamcinchak
changed the title
output prop with fnoutput prop with fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queueing up per migration plan: https://docs.google.com/spreadsheets/d/1Vtxp5BLweDPDooQoNhgOCYjCIBPRYIcOuyArGJRqOkI/edit?gid=0#gid=0
Planx-core counterpart here theopensystemslab/planx-core#593