Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following #270 , it allows
houseSize
in the input to be undefined, so that it becomes an optional parameter. Ifundefined
, the value is then mapped to the number of bedrooms.#How?
The value is made optional in the
formSchema
andcalculationSchema
. Note thathouseSize
is not necessary to fetch the data in the API. Later, when theProperty
class is actually constructed, there is an if condition that checks ifhouseSize
exists or needs to be mapped.#Anything else?
We used to have a file named
testClasses.ts
but it was not a test. The main function within it was calledcalculateFairhold
. I think the name was confusing, so I renamed itcalculateFairhold.ts
. Last, I added a series on unit tests incalculateFairhold.test.ts