Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: fix placeholder copy in form #263

Merged
merged 2 commits into from
Jan 10, 2025
Merged

nit: fix placeholder copy in form #263

merged 2 commits into from
Jan 10, 2025

Conversation

zz-hh-aa
Copy link
Collaborator

@zz-hh-aa zz-hh-aa commented Jan 9, 2025

NB: we are using 0 for newbuild age now

Q: see comment in line 330 (should we hook up the mortgage variable explainers to the actual constants so we don't have to maintain them in two places?)

@zz-hh-aa zz-hh-aa requested a review from a team January 9, 2025 17:48
@zz-hh-aa zz-hh-aa marked this pull request as ready for review January 9, 2025 17:48
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 9:28am

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches here thanks!

re: Maintaining the variables - yes, ideally we'd import them in here (they're coming from /models right?) - this is a great shout.

@zz-hh-aa
Copy link
Collaborator Author

Just before I merge-- @DafyddLlyr in new commit 8db84c1 do you think it makes sense that I moved the mortgage variables from Mortgage.ts to constants.ts since they now need exporting / are used in multiple places? I always looked for them in the wrong place before anyway (always though they'd be in contants.ts...)

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @zz-hh-aa ! 🙌

@zz-hh-aa zz-hh-aa merged commit cb7e61b into main Jan 10, 2025
5 checks passed
@zz-hh-aa zz-hh-aa deleted the oz/copy-fixes branch January 10, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants