bug: fix issue with atlas migrations + search field #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Funkhouser <[email protected]>
golanglemonade
requested review from
matoszz,
LemonAid711 and
theopenlane-bender
auto-merge was automatically disabled
January 19, 2025 06:35
Pull request was converted to draft
Signed-off-by: Sarah Funkhouser <[email protected]>
golanglemonade
changed the title
|
matoszz
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using atlas auto migrations (which we use in our tests) I was getting this error:
Using the
postgres.TypeBigSerialand not the default expr seems to fix this; the default expression was used because with with justSERIALwe would get an error for a required field not being set.Fixes the return of
Valueto be anintinstead of a string, when querying the database we need an int, the return to the user is a string. Tests updated to reflect the correct values.