Feat/read me #26
Merged
Feat/read me #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuvCharles
force-pushed
the
feat/read-me
branch
from
ecf911e to
a826e39
Compare
skpn
reviewed
Dec 20, 2023
| @@ -48,7 +48,7 @@ const normalizeProductOption = (option: SyliusProductOption): ProductOption => ( | |||
| }); | |||
|
|
|||
| export const normalizeProductImage = (image: SyliusProductImage): Image => ({ | |||
| url: process.env.NEXT_PUBLIC_SYLIUS_API_URL + image.path, | |||
| url: process.env.NEXT_PUBLIC_SYLIUS_BACKEND_API + image.path, | |||
There was a problem hiding this comment.
pourquoi ça utilisait pas SYLIUS_STORE_DOMAIN ça ? je suis ok pour avoir une seule variable mais je trouve ça bizarre
There was a problem hiding this comment.
bah ça faisait vraiment doublon
| @@ -72,7 +72,6 @@ export function AddToCart({ | |||
| }) { | |||
| const [message, formAction] = useFormState(addItem, null); | |||
| const searchParams = useSearchParams(); | |||
| const [isPending, startTransition] = useTransition(); | |||
There was a problem hiding this comment.
ça marche plus en next 14 ? et c'était pas utilisé ?
There was a problem hiding this comment.
juste pas utilisé j'ai chié le rebase
| - Upgrades search to include typeahead with dynamic re-rendering, vector-based similarity search, and JS-based configuration. | ||
| - Search runs entirely in the browser for smaller catalogs or on a CDN for larger. | ||
| 1. You need a [Sylius](https://sylius.com/download/) instance, either in the cloud or self-hosted. | ||
| 2. Follow the Read-Me of this [repository](https://github.com/theodo/sylius-commerce-config) to configure your Sylius Project |
There was a problem hiding this comment.
c'est pas bizarre de renvoyer sur un autre repo en vrai ? parce qu'on dit qu'il y a besoin de n'importe quelle instance standard de sylius, et après on envoie sur un sylius spécifique
There was a problem hiding this comment.
en v0 on peut renvoyer sur ce repo avec les fichiers de serialisation a custom
DuvCharles
force-pushed
the
feat/read-me
branch
from
a826e39 to
43269bc
Compare
skpn
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.