Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid 'is False' #251

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Avoid 'is False' #251

merged 1 commit into from
Mar 30, 2021

Conversation

tovrstra
Copy link
Member

The old code goes against PEP8. See https://www.python.org/dev/peps/pep-0008/ (Look for Don't compare boolean values to True or False) A similar issue in pdb.py is being fixed in PR #250.

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #251 (a80dc95) into master (4a9b322) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files          74       74           
  Lines        8048     8048           
  Branches     1040     1040           
=======================================
  Hits         7691     7691           
  Misses        169      169           
  Partials      188      188           
Impacted Files Coverage Δ
iodata/formats/mol2.py 89.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a9b322...a80dc95. Read the comment docs.

@tovrstra tovrstra merged commit db83001 into theochem:master Mar 30, 2021
@tovrstra tovrstra deleted the fix-boolean-tests branch March 30, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant