New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the magnitude of negative density values #157

Merged

FarnazH merged 2 commits into master from resolve_issue_117

Jan 12, 2024

Member

FarnazH commented Jan 11, 2024

Following PR #136, the magnitude of negative density values is checked following our discussion in issue #117.

Checklist

Write a good description of what the PR does.
Add tests for each unit of code added (e.g. function, class)
Update documentation
Squash commits that can be grouped together
Rebase onto master

Type of Changes

	Type
✓	🐛 Bug fix

Related

Closes #117


Check the magnitude of negative density values

a438b3a

See issue #117

FarnazH requested review from PaulWAyers and maximilianvz

January 11, 2024 21:16


[pre-commit.ci] auto fixes from pre-commit.com hooks

314a6d1

for more information, see https://pre-commit.ci

Collaborator

maximilianvz commented Jan 11, 2024 •

edited

Loading

This looks good to me, @FarnazH. I think it can be merged.

PaulWAyers reviewed

View reviewed changes

Member

PaulWAyers left a comment

My only vommrny is that in line 624 of density.py the comment should be "check for negative pos. kinetic energy density value" (no "density value" which was appropriate in the first instance but not this one. Otherwise looks great.

Member Author

FarnazH commented Jan 12, 2024

@PaulWAyers, I wanted to keep the comment to one line, that's why I didn't use the whole property name of "negative pos. kinetic energy density", and just sufficed to use density (as it is a density after all).

FarnazH merged commit a71c361 into master

0 of 9 checks passed

FarnazH deleted the resolve_issue_117 branch

January 12, 2024 06:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment