Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup.py to fix install problem #156

Closed
wants to merge 1 commit into from

Conversation

marco-2023
Copy link
Contributor

Gbasis has three folders in its main level and pypi gets lost during the the discovery of top-level packages during the installation. With this the package directory is set.

Checklist

  • Write a good description of what the PR does.
  • Add tests for each unit of code added (e.g. function, class)
  • Update documentation
  • Squash commits that can be grouped together
  • Rebase onto master

Type of Changes

Type
🐛 Bug fix

Related

Gbasis has three folders in its main level and pypi gets lost during the
the discovery of top-level packages during the installation. With this
the package directory is set.
Copy link
Member

@FarnazH FarnazH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marco-2023, we are using pyproject.toml instead of setup.py; see #148.
I leave it to @Ali-Tehrani and @RichRick1 to resolve the issue you have encountered.

@Ali-Tehrani
Copy link
Collaborator

Sorry for causing this to be an issue. Right now, if you try to install under editable mode it doesn't work: pip install -e. But once this pull-request is merged #151, then you should be able to. Other than that, I can't imagine what other installation problems can occur, because all of the github actions pass on windows and linux.

@marco-2023
Copy link
Contributor Author

@Ali-Tehrani that is perfect, I will close this PR and work on the branch corresponding to PR #151. I noticed it because at the time I could not make a fresh installation.

image

@marco-2023 marco-2023 closed this Jan 11, 2024
@marco-2023 marco-2023 deleted the fix_install branch January 11, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants