Updated tmhOAuth.php to support RSA-SHA1 Signing. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 6, 2014 22:57
I chose this library to handle OAuth authentication for a Xero Integration project, which worked great until using it for 'Private' applications (http://developer.xero.com/documentation/getting-started/private-applications/). Xero uses HMAC-SHA1 for public/partner applications and the RSA-SHA1 signature method for Private applications, which tmhOAuth doesn't support. As Xero usage is growing rapidly, it'd be nice to incorporate these features into the main library.
|
Hi Matt, could you please review these changes? Thanks. |
|
i was looking at this. can you also add a test to https://github.com/themattharris/tmhOAuthTest that i can run against this code. once i can run the tests i'll work on integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I chose this library to handle OAuth authentication for a Xero Integration project, which worked great until using it for 'Private' applications (http://developer.xero.com/documentation/getting-started/private-applications/). Xero uses HMAC-SHA1 for public/partner applications and the RSA-SHA1 signature method for Private applications, which tmhOAuth doesn't support.
As Xero usage is growing rapidly, it'd be nice to incorporate these features into the main library.