-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nick Colours for v4.4.0 #7
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably adapt the theme so that only the new selectors remain.
The old ones aren't useful once we release the new TL version.
As for the commit messages, it isn't a regression but a change that was done on purpose, so please reword that ;)
It was a regression for the morning theme, as there the change was forgotten originally. It isn't for normal themes that just update for the new version of the code.
theme.css
Outdated
@@ -211,6 +211,42 @@ form.message-search input { | |||
color: var(--body-color); | |||
} | |||
|
|||
/* Nick Colour Fix for 4.4.0 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get rid of that comment, it isn't useful in the future for readers of the code.
They will be working with the latest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment removed below.
2060b3c
to
d4fc4d8
Compare
This doesn't just update the selector, but completely modifies the colors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fixed up to do the minimal changes necessary
So it should be (example) .user.color-1 { color: #ef4657; } .user.color-2 { color: #ff93a4; } etc etc ? I think I got it this time, correct me if I'm wrong again. |
No, there's no need to duplicate the color. |
3d841f5
to
a76e755
Compare
PR #4649 update for `#chat.colored-nicks` CSS selector. Update Nick Colours for v4.4.x
PR #4649 update
#chat.colored-nicks
CSS selector.