Began adding an R-native writer. #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to read HDF5-backed arrays properly.
|
Just a heads up on this, I will be making some changes to the on disk format of AnnData for the next release. Most of these changes will just be adding metadata to written elements so we are never inferring how to read them back in. This metadata will include a name of the type and a version for the encoding. See scverse/anndata#554 for details. In short, maybe hold off on merging this until that's through? These changes should be landing on the development branch on AnnData before the end of June. |
|
I'm down for that. We're close to the next BioC release and I'd like to spend what time we have left on checking the reader. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much as it says. Missing all the sparse bits and pieces for
obsp,varpand the sparse layers; this is waiting on grimbough/rhdf5#80. Will need some testing, as usual; I haven't verified that it works with Python, but it does at least work with the R-native reader. (One nice property of the zellkonverter set-up is that we can easily check one implementation against the other.)Wait for #46 to resolve before we even consider merging this bad boy.