Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /preprocessing_visualization/quality_control.html #275

Open
emiliosk opened this issue May 17, 2024 · 0 comments
Open

Issue on page /preprocessing_visualization/quality_control.html #275

emiliosk opened this issue May 17, 2024 · 0 comments
Assignees

Comments

@emiliosk
Copy link

emiliosk commented May 17, 2024

Hi,

Maybe it's not a typical issue but just a question on why you have chosen to apply the SoupX pipeline in this way.
You have written:

sc = SoupChannel(data_tod, data, calcSoupProfile = FALSE)
soupProf = data.frame(row.names = rownames(data), est = rowSums(data)/sum(data), counts = rowSums(data))

However, by estimating the contamination with est = rowSums(data)/sum(data), you are estimating the contamination without data of the empty droplets at all. So it does not yield then the effectivity as in the own publication of SoupX.

Basically saying you could run everything just like this:
sc = SoupChannel(data, data, calcSoupProfile = FALSE)
soupProf = data.frame(row.names = rownames(data), est = rowSums(data)/sum(data), counts = rowSums(data))

and it would give you similar results.

So I wonder why you chose to perform the estimation manually and not the automatic estimation, which does take the empty droplets into account.

Thanks a lot! I appreciate your resource!

Best,
Emilio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants