Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TheiaCoV] Reorder flu segments from largest to smallest in irma task #635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Michal-Babins
Copy link
Contributor

@Michal-Babins Michal-Babins commented Sep 30, 2024

This PR closes #630

🗑️ This dev branch should be deleted after merging to main.

🧠 Summary

PR updates TheiaCoV workflow for when "flu" organism is chosen, and reorders flue segments from largest to smallest in the irma task.

⚡ Impacted Workflows/Tasks

wf: TheiaCov
task: task_irma

This PR may lead to different results in pre-existing outputs: Yes

This PR uses an element that could cause duplicate runs to have different results: Yes/No

🛠️ Changes

Changes take expected flu segment lengths (large to small) and concatenates them in the irma task to the irma consensus fasta in descending order

⚙️ Algorithm

In task_irma.wdl for the flu track of TheiaCoV, the process for creating the consensus fasta was updated to order the flu segments from largest to smallest segments=("PB2" "PB1" "PA" "HA" "NP" "NA" "MP" "NS") as per request, updating the assembly_fasta output.

➡️ Inputs

⬅️ Outputs

  • assembly_fasta (when flu track is triggered)

🧪 Testing

This PR was tested against flu data found in the flu_testing table here. The workspace for testing this data can be found here.

Further testing was done on the theiacov validation set against WNV and MPXV

Suggested Scenarios for Reviewer to Test

Test with flu set from flu_testing table here. For flu ensure output fasta are in the following order of segments: segments=("PB2" "PB1" "PA" "HA" "NP" "NA" "MP" "NS"). Test with validation sets of your choosing.

🔬 Final Developer Checklist

  • The workflow/task has been tested and results, including file contents, are as anticipated
  • The CI/CD has been adjusted and tests are passing (Theiagen developers)
  • Code changes follow the style guide
  • Documentation and/or workflow diagrams have been updated if applicable (Theiagen developers only)

🎯 Reviewer Checklist

  • All changed results have been confirmed
  • You have tested the PR appropriately (see the testing guide for more information)
  • All code adheres to the style guide
  • MD5 sums have been updated
  • The PR author has addressed all comments
  • The documentation has been updated

@Michal-Babins Michal-Babins marked this pull request as ready for review September 30, 2024 14:53
@Michal-Babins Michal-Babins requested a review from a team as a code owner September 30, 2024 14:53
@sage-wright sage-wright changed the title [TheiaCoV]Reorder flu segments from largest to smallest in irma task [TheiaCoV] Reorder flu segments from largest to smallest in irma task Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TheiaCoV] Reorder flu assembly segments in largest-to-smallest order
1 participant