[TheiaCoV] Reorder flu segments from largest to smallest in irma task #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #630
🗑️ This dev branch should be deleted after merging to main.
🧠 Summary
PR updates TheiaCoV workflow for when "flu" organism is chosen, and reorders flue segments from largest to smallest in the irma task.
⚡ Impacted Workflows/Tasks
wf: TheiaCov
task: task_irma
This PR may lead to different results in pre-existing outputs: Yes
This PR uses an element that could cause duplicate runs to have different results: Yes/No
🛠️ Changes
Changes take expected flu segment lengths (large to small) and concatenates them in the irma task to the irma consensus fasta in descending order
⚙️ Algorithm
In task_irma.wdl for the flu track of TheiaCoV, the process for creating the consensus fasta was updated to order the flu segments from largest to smallest
segments=("PB2" "PB1" "PA" "HA" "NP" "NA" "MP" "NS")
as per request, updating the assembly_fasta output.➡️ Inputs
⬅️ Outputs
🧪 Testing
This PR was tested against flu data found in the flu_testing table here. The workspace for testing this data can be found here.
Further testing was done on the theiacov validation set against WNV and MPXV
Suggested Scenarios for Reviewer to Test
Test with flu set from flu_testing table here. For flu ensure output fasta are in the following order of segments:
segments=("PB2" "PB1" "PA" "HA" "NP" "NA" "MP" "NS")
. Test with validation sets of your choosing.🔬 Final Developer Checklist
🎯 Reviewer Checklist