Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerabilities in node packages. #1553

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Fix vulnerabilities in node packages. #1553

merged 1 commit into from
Sep 2, 2024

Conversation

ewelinagr
Copy link
Member

According to yarn audit this solves 33 vulnerabilities. There are 3 left that require more changes:

  • 2 of them (moderate and high level) are introduced by react-scripts - react scripts are no longer activly maintained, so we should find an alternative
  • 1 of them (moderate) introduced by webdav package - unfortunately in webdav-client version >= 5 there was a switch to fetch from axios - this doesn't work well for us in case of file uploads (issues caused on the backed side) - see Switch to fetch from axios broke File/Blob uploads perry-mitchell/webdav-client#352, also fetch doesn't allow tracking uploads. We need to investigate switching to version >=5 (impact of fetch for the webdav related oprations) or consider switching to other package instead of https://www.npmjs.com/package/webdav

@ewelinagr ewelinagr requested a review from tgreenwood August 27, 2024 13:01
@tgreenwood
Copy link
Contributor

Thanks for details, let's plan the investigation. And good job with the fix!

@ewelinagr ewelinagr merged commit db5987f into dev Sep 2, 2024
6 checks passed
@ewelinagr ewelinagr deleted the vulnerabilities branch September 2, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants