Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
apps/greencheck
module to handle additional ASN-related exceptions and improve the robustness of the domain checker. The most important changes include expanding the list of exceptions handled in thecheck_for_matching_asn
method and updating the corresponding tests to ensure all new exceptions are properly caught and logged.Exception Handling Improvements:
apps/greencheck/domain_check.py
: Added new ASN-related exceptions (ASNRegistryError
,ASNOriginLookupError
,ASNLookupError
) to the import list and updated thecheck_for_matching_asn
method to handle these exceptions. [1] [2]Test Enhancements:
apps/greencheck/tests/test_domain_checker.py
: Modified thetest_asn_from_ip_fails_gracefully_with_bad_asn_lookup
test to usepytest.mark.parametrize
for testing multiple exception types, ensuring that all new exceptions are properly caught and logged.