chore(sinan DAGS): create DAG to fetch dengue data from SINAN #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luabida
force-pushed
the
create-sinan-dags
branch
from
89c1f65
to
c0cee37
Compare
fccoelho
requested changes
Oct 11, 2023
| except ProgrammingError as error: | ||
| if str(error).startswith("(psycopg2.errors.UndefinedColumn)"): | ||
| # Include new columns to table | ||
| column_name = str(error).split('"')[1] |
There was a problem hiding this comment.
I think that obtaining the missing column name from the error message is not a good approach, because if psycopg2 changes the wording in their error messages it will break our code. I think we should instead look at the list of column names of the parquet files and compare them with the columns in the current schema. From the difference in these lists, which can be efficiently obtained as list(set(cols1)-set(cols2)), we can then create the alter table query adding the new columns to the database table. With this approach, we don't even need to rely on an exception being raised. This determination of the missing columns can be done before the first insert.
| logging.debug(f"{file} inserted into db") | ||
| try: | ||
| insert_parquets(parquets.path, year) | ||
| except ProgrammingError as error: |
fccoelho
reviewed
Oct 16, 2023
luabida
force-pushed
the
create-sinan-dags
branch
from
f6f0cd7
to
c76c431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.