Use the smart_proxy_plugin.yml reusable GHA workflow #95
+9
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is largely the same as test-gem, except it verifies that it at least implements support for Ruby versions that the Smart Proxy wants. It also implements the version selector by respecting SMART_PROXY_BRANCH in the Gemfile.
By using GitHub Actions we no longer need Jenkins.
|
I don't think the test failure is related. |
|
Correct, it's a bad test that was (accidentally) broken by theforeman/smart_proxy_dynflow@d6e6a73 |
evgeni
reviewed
Nov 29, 2024
Comment on lines
-35
to
+41
| assert_equal 1, runner.publish_exit_status(0) | ||
| runner.publish_exit_status(0) | ||
| updates = runner.generate_updates | ||
| assert_equal 1, updates[{:suspended_action => nil}].exit_status | ||
| runner.publish_data('jid: 12345', 'stdout') | ||
| assert_equal 0, runner.publish_exit_status(0) | ||
| runner.publish_exit_status(0) | ||
| updates = runner.generate_updates | ||
| assert_equal 0, updates[{:suspended_action => nil}].exit_status |
There was a problem hiding this comment.
@adamruzicka would you mind having a look here whether the test fix looks sane to you? :)
There was a problem hiding this comment.
Looks good, thank you.
adamruzicka
approved these changes
Nov 29, 2024
|
Thanks for the test fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely the same as test-gem, except it verifies that it at least implements support for Ruby versions that the Smart Proxy wants. It also implements the version selector by respecting SMART_PROXY_BRANCH in the Gemfile.
It also cleans up the Jenkins integration.