Add facts_match_regex parameter in katello class #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archanaserver
force-pushed
the
add-parameter
branch
from
b97f2fa
to
dd43e4b
Compare
|
The acceptance tests are failing due to outside forces. EL8 due to CentOS 8 Stream repositories going away and EL9 due to nightl ybeing in transition post branching. A basic unit test for this parameter would be nice to have. |
archanaserver
force-pushed
the
add-parameter
branch
from
dd43e4b
to
1ae056d
Compare
|
This is working fine now \o/ |
archanaserver
changed the title
ehelms
approved these changes
Jun 27, 2024
|
#504 fixes up the minimum version dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference: theforeman/puppet-candlepin#262 (review)
This PR adds
facts_match_regexparameter support tokatello::candlepin. It enables filtering consumer facts via regex patterns, enhancing configuration flexibility and control.Changes Made
facts_match_regexparameter inkatello::candlepin.katelloclass to passfacts_match_regextokatello::candlepin.