Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in hammer_root.yml.epp #1173

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

asteflova
Copy link
Member

This fixes a small typo in hammer_root.yml.epp. (It was previously fixed in theforeman/hammer-cli-foreman@11c2bf5.)

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail because we also have the statement there:

# Credentials. You'll be asked for the interactively if you leave them blank here

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed one so the tests are still failing

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually fixed it up so I can release it.

@ekohl ekohl enabled auto-merge (rebase) August 13, 2024 13:02
@ekohl ekohl merged commit 2eb6df8 into theforeman:master Aug 13, 2024
19 checks passed
@asteflova
Copy link
Member Author

Thanks @ekohl and sorry for taking so long, I was going to take a look later this week.

@ekohl ekohl added the Bug label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants