run Katello rubocop without Foreman checkout #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foreman limits the rubocop version, so we we end up using the one defined by Foreman, not by Katello, but Katello's rubocop_todo is not compatible with that.
|
Katello updated to tfm-rubocop 0.1.x in Katello/katello#11009 Now running rubocop from the Foreman checkout for Katello fails with: This change (untested) avoids that, by replicating the setup we have on GHA, where rubocop runs exclusively on the Project (= Katello) checkout, w/o Foreman. |
ekohl
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foreman limits the rubocop version, so we we end up using the one
defined by Foreman, not by Katello, but Katello's rubocop_todo is not
compatible with that.