limit PR tests to 3.9/4.11, newer releases can use GHA #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we want to pick to 3.9/4.11 too so it's consistent? |
|
we surely can. I was playing safe here. |
|
Let's play it less safe: theforeman/foreman#10134 and then drop them all. |
ekohl
reviewed
Apr 19, 2024
| @@ -32,26 +32,19 @@ echo "Create theforeman.org/yaml/jobs/test_${FOREMAN_VERSION/./_}_stable.yaml" | |||
| echo "Add ${FOREMAN_VERSION%*.} as a minor to theforeman.org/yaml/views/release.yml" | |||
|
|
|||
| # TODO The sed line was too complex | |||
| echo "Add the following to the foreman_integration_versions section in theforeman.org/pipelines/test/foreman/vars.groovy" | |||
| echo "Update .github/workflows/foreman.yml in foreman.git and set plugin_version for Katello like this:" | |||
There was a problem hiding this comment.
I think this branch script should be limited to just this repository.
|
Alternative was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs