Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test using rbenv for foreman-installer tests #442

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Apr 11, 2024

There are a couple implications here:

  1. Using a node wide cache for rubygems to speed bundle install up
  2. Using shell based rbenv to prevent clashes between instances

@ehelms ehelms force-pushed the use-rbenv branch 2 times, most recently from 86236ff to ad775dd Compare April 12, 2024 01:30
@ehelms ehelms marked this pull request as ready for review April 18, 2024 13:46
withRuby(version, command)
}

def withRuby(version, command) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative approach would be to include a check for if a particular environment variable is set (e.g. RUBY_VERSION) then use it unless version is explicitly specified. That would allow not having to pass the ruby version as the first argument everytime if we find that annoying.

@ehelms
Copy link
Member Author

ehelms commented Apr 18, 2024

This initial change includes:

  • Set of shared library to setup and run in rbenv context
  • conversion of foreman-installer-pr-test job to show how it will look
  • a simple ruby test job that allows more easily testing changes to how Ruby test code works

@ehelms ehelms merged commit 2c160b8 into theforeman:master Apr 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants