SAT-30393 - Skip recurring logic tasks if on prem is enabled

[chris1984]

This PR adds a skip to inventory/insights/generate report scheduled sync tasks if on_prem is enabled. This includes a change @jeremylenz has in his pr, once that is merged, I will remove it from here.

[jeremylenz]

I notice this approach just skips planning the scheduled sync tasks if we're using the local advisor engine. This should work fine, but you'd still see actions in Dynflow that are empty and successful.

Another option is to avoid scheduling them at all here -->

foreman_rh_cloud/lib/foreman_rh_cloud/engine.rb

Line 168 in dc80828

ForemanRhCloud::Engine.register_scheduled_task(InsightsCloud::Async::InsightsScheduledSync, '0 0 * * *')

But that may be a bit less safe because of where and when ForemanRhCloud.with_local_advisor_engine? is defined..? I'm a bit unclear on if that will work, but if it does it seems cleaner to me.

@ShimShtein @parthaa thoughts?

[parthaa]

I notice this approach just skips planning the scheduled sync tasks if we're using the local advisor engine. This should work fine, but you'd still see actions in Dynflow that are empty and successful.

While I agree you'd rather not have tasks scheduled if not needed. I am thinking in the future when we may want the hybrid option. I have a feeling we are better of scheduling but skipping.