Fixes #910 - Insights tab displayed for non-RHEL hosts #911
Conversation
- Add helper-function isNotRhelHost - Hide insights tab based on host-OS - Hide TotalRisk card based on host-OS
|
|
||
| export const isNotRhelHost = ({ hostDetails }) => | ||
| // eslint-disable-next-line camelcase | ||
| !new RegExp('red\\s?hat', 'i').test(hostDetails?.operatingsystem_name); |
There was a problem hiding this comment.
operatingsystem_name is not safe as this value can be changed by the user. As this plugin depends on Katello anyways, you can use hostDetails?.operatingsystem_family
There was a problem hiding this comment.
Well, you will get the OS type Redhat for Alma, Rocky, etc. as well, so this is tricky... But maybe you can use it for a sanity check.
There was a problem hiding this comment.
There is no better check for this right now. I would just go with this solution.
There was a problem hiding this comment.
What about checking at least for RHEL ? I don't know how people are naming their OSes these days.
There was a problem hiding this comment.
on Redhat, these OS are created automatically from the imported Manifest.
Other areas will not work if OS name was changed, like https://github.com/theforeman/foreman/blob/develop/app/views/unattended/provisioning_templates/snippet/insights.erb#L10
|
Will take a look |
|
ACK, works great. Thanks @Thorben-D I am not seeing the insights tab for my Ubuntu 24.04 box Before PR: After PR: |
|
@Thorben-D I am not seeing the insights tab for a normal RHEL host now, is this something you are able to investigate? |
|
|
|
@chris1984 Thanks for having a look! Does the OS name of your RHEL host not contain any permutation of "Red Hat"? |
|
#911 (comment) That is what is was talking about :) |
|
@Thorben-D my host name is |
|
I wonder if you could use the distribution facts like here |
|
The Icon way, would work as well I think |
|
@Thorben-D Do you think you can revisit this next week? Otherwise, I will prob have to revert the commit, so it does not affect our tests downstream when we do our weekly nightly/stream builds. |
|
@chris1984 Not before wednesday I'm afraid. If that is too late, you'll have to revert the commit. |
Fixes #910
Changes made
The isNotRhelHost check is not the nicest but this is similar to how it is done in:
provisioning_templates/snippet/insights.erb:<% if @host.operatingsystem.name == 'RedHat' -%>