-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inventory page UX enhancements #860
base: foreman_3_9
Are you sure you want to change the base?
Inventory page UX enhancements #860
Conversation
JS Ci is fixed in #861 |
@jameerpathan111 @chris1984 @ShimShtein due to the amount of components movement we can postpone this change to the branch that aligns with foreman_3_10, I guess this might affect some of our automation/docs. |
0eb8107
to
72589a1
Compare
- Moved the page description into a modal which is reachable from the dropdown kebab. - Moved also the settings card into a modal. - Small margin/padding fixes. - replace PF3 Buttons with PF4 Buttons.
72589a1
to
0d581c3
Compare
I think we will need UX approval for this one... |
Hey @MariSvirik, what do you think about this look for the new year? :) Was thinking to move the dropdown kebab to the buttons row and add a bit more spacing between them, what do you think? |
To add some context: I think that inventory upload is just one aspect of the RH communication status, so having it as a central thing, while hiding away settings controls feels a bit less natural. As for hiding the "About" part - I don't have a strong opinion about it, but still would like to present the user if not the full text, but at least a "clue" that there is a more detailed text without hiding it in the kebab. |
Agree, maybe some indicator under the page title would be good.
In most of the pages in Satellite we have "Documentation" button, maybe that will be better for consistency? |
@Ron-Lavi But we can talk about it. What to keep or change. |
@MariSvirik it looks much better than my UX mess :) Shim any fresh thoughts about those designs? Thanks |
Once you merge this one in and the docs one, I will do a new release so we got both bz's into post state |
As discussed with Shim and Maria, we will leave the major changes to the release with Foreman 3.10/3.11 and can do some smaller enhancements instead for 3.9 Moving to draft meanwhile |
Sounds good, will just wait for you to merge the docs one and then will get everything bundled up |
I liked the draft UI sketched by @MariSvirik and it looks more organized. From the text side, I will have some minor inputs. When we initiate this, I can provide my suggestion 👍 |
Screenshot of the previous look:
Screenshots of the new look: