Always include the installer answer file in backups #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user has changed the answer file location in their scenario to something outside of /etc/foreman-installer then it isn't backed up. This changes the installer feature's config_files to include it if needed. It also stops globbing the files and simply trust that you can list a directory, which we already do for the cached data.
evgeni
force-pushed
the
include-installer-answer-file-in-backup
branch
from
9123a8e
to
5320345
Compare
|
Rebased and fixed tests. I think this should have no implications on restores. |
|
Thanks for fixing up the tests. |
evgeni
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has changed the answer file location in their scenario to something outside of
/etc/foreman-installerthen it isn't backed up.This changes the installer feature's config_files to include it if needed. It also stops globbing the files and simply trust that you can list a directory, which we already do for the cached data.
I'm unsure about the implications for restores.
Note that this also prepares for the case where we will move the answer files to
/var/lib/foreman-installer(provided we keep the scenario files in/etc).