-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37175: Add dedicated update command #802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
force-pushed
the
add-update-command
branch
from
February 16, 2024 20:49
cc423fa
to
9293128
Compare
ehelms
force-pushed
the
add-update-command
branch
from
April 9, 2024 19:59
9293128
to
e72282c
Compare
ehelms
force-pushed
the
add-update-command
branch
5 times, most recently
from
April 16, 2024 20:16
a87bf9d
to
3ab2179
Compare
Griffin-Sullivan
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from the point of view that I tested this and it works, but can't speak to the code here.
1 task
evgeni
reviewed
Apr 22, 2024
evgeni
reviewed
Apr 22, 2024
Overall I think this makes sense |
ehelms
force-pushed
the
add-update-command
branch
from
April 22, 2024 12:00
3ab2179
to
6b9403f
Compare
ehelms
force-pushed
the
add-update-command
branch
from
April 23, 2024 13:11
6b9403f
to
78a269e
Compare
Rebased on to the fixes for the Debian |
SatelliteQE/robottelo#14883 passed PRT |
evgeni
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds a dedicated command for z-stream style updates and is intended to be run like:
This introduces a dedicated update scenario intended to work for all installation scenarios letting the various checks and processes handle the state of the system (e.g. what installer scenario is present). This does not remove using the upgrade command to do a z-stream "upgrade" as my goal is to introduce a new update command alongside these first before doing major demolition.
I am putting this in draft status for now in order to add testing.