Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37629 - Support zeitwerk loader #142

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

ShimShtein
Copy link
Member

No description provided.

@ShimShtein
Copy link
Member Author

@ofedoren Can you take a look?

@ShimShtein ShimShtein force-pushed the zeitwerk branch 2 times, most recently from d3dd51e to cfbe789 Compare July 4, 2024 14:57
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ShimShtein, LGTM.

Note for maintainer: ensure that changes in workflow file and in gemfile.d are removed before merging.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped the temporary bits.

@ekohl ekohl merged commit 798f642 into theforeman:master Sep 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants