Fixes #36666 - Add support for "channel" parameter #130
+29
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreamtp
changed the title
stejskalleos
requested changes
Sep 20, 2023
andreamtp
force-pushed
the
36666-channel
branch
from
6673d1a
to
91d9655
Compare
stejskalleos
requested changes
Nov 8, 2023
andreamtp
force-pushed
the
36666-channel
branch
from
91d9655
to
9f6a387
Compare
andreamtp
force-pushed
the
36666-channel
branch
2 times, most recently
from
b6b17f1
to
7fbd3ae
Compare
This commit introduce the possibility to pass the "channel" parameter to leapp, so during an upgrade can be targetted release 8.6 EUS, even if source is 7.9 "plain". Channels list is take from upstream: https://github.com/oamg/leapp-repository/blob/84d6ce3073e646e8740b72a5e7edda056c1b324a/commands/preupgrade/__init__.py#L28 ref. https://projects.theforeman.org/issues/36666
andreamtp
force-pushed
the
36666-channel
branch
2 times, most recently
from
63a1bf4
to
15fbc7d
Compare
|
I've addressed all requested changes, can this PR be reviewed please? |
stejskalleos
requested changes
Jan 24, 2024
Co-authored-by: Leos Stejskal <[email protected]>
Co-authored-by: Leos Stejskal <[email protected]>
|
Thanks, done. Unfort. packit fails for unrelated problems... |
stejskalleos
approved these changes
Feb 13, 2024
|
Thanks @andreamtp ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduce the possibility to pass the "channel" parameter to
leapp, so during an upgrade can be targetted release 8.6 EUS, even if
source is 7.9 "main".
ref. https://projects.theforeman.org/issues/36666