Fixes #37997 - Support Rails 7.0 #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Nov 12, 2024
ofedoren
force-pushed
the
feat-37997-support-rails-7
branch
from
da74a6b to
ea56aac
Compare
|
Removed the commit for testing with opened PR, ready for merge. |
| @@ -42,7 +42,9 @@ class DiscoveredHostsTest < IntegrationTestWithJavascript | |||
| page.find_link('Reboot').click | |||
| wait_for_ajax | |||
| assert page.has_text?('The following hosts are about to be changed') | |||
| page.find_button('Submit').click | |||
| wait_for do | |||
There was a problem hiding this comment.
What's the reason to put this particular click action into the wait_for block?
Other tests have it as well; should we update them as well?
There was a problem hiding this comment.
For some reason some integration tests fail either on timeouts or (like in this case) the app seems to not respond
(with either data or page) in a certain time. Not sure if it's frontend or backend related, but waiting for a bit more helps :/
There was a problem hiding this comment.
Oh yes, the daily joys of maintaining integration tests.
If it helps, +1 from me.
stejskalleos
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.