Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37418 - Fixes an issue that caused hidden Ansible variables to be shown in plain text on the Host-Details page #717

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixes #37418 - Fixes an issue that caused hidden Ansible variables to be shown in plain text on the Host-Details page #717

wants to merge 5 commits into from

Commits on May 8, 2024

  1. Fixes #37417 - OverriddenAnsibleVariablePresenter GraphQL scheme inco… 

    …rrect for hidden_value and override
    @Thorben-D
    Thorben-D committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1b2ed8b View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Add the env var

    @hosekadam @Thorben-D
    hosekadam authored and Thorben-D committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    00c8843 View commit details
    Browse the repository at this point in the history

  2. Fixes #37404 - Drop webpacked_plugins_css_for from code

    @Thorben-D
    Thorben-D committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0db5002 View commit details
    Browse the repository at this point in the history

  3. Fixes #37418 - Fixes an issue that caused hidden Ansible variables to… 

    … be shown in plain text

on the Host-Details page

- Add "hiddenValue" to GraphQL query hostVariableOverrides.gql
- Replace plain text secret with masked value
- Adds a parameter "redact_secrets" to AnsibleInventoriesController#show_inventory
- Change frontend code to use newly added "redact_secrets" parameter
- Add a new "to_hash_with_secrets_redacted" method to InventoryCreator
- Hide hidden values in GQL response by if edit_ansible_variables not granted
    @Thorben-D
    Thorben-D committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    aba8374 View commit details
    Browse the repository at this point in the history

  4. EXP: Prevent hidden variables from being shown through ansible invent… 

    …ory and api/v2/ansible_variables if a user does not posess the "edit_ansible_roles" permission
    @Thorben-D
    Thorben-D committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cfb1bc0 View commit details
    Browse the repository at this point in the history