Sample actions for tasks development #392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A set of actions with pre-defined behaviour for easier simulation of various tasks states: these actions are development only.
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
adamruzicka
reviewed
Jun 14, 2019
app/lib/actions/try.rb
Outdated
| # | ||
| # # Task that fails but resumes (ending in stopped state/warning result) | ||
| # ForemanTasks.sync_task(Actions::Try::Skip) | ||
| unless Rails.env.production? |
There was a problem hiding this comment.
I'd move this one level higher so we won't end up with empty Actions::Try module in production environments
|
@ezr-ondrej opinions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of actions with pre-defined behaviour for easier simulation of
various tasks states: these actions are development only.